Add global typings to path #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hoxyq
approved these changes
Mar 12, 2024
|
@EdmondChuiHW, note that you ended up merging a commit with an unclear title to |
Author
|
@motiz88 sorry. Thought the squash-and-merge option would take the PR title. Will make sure to double-check that in the future |
EdmondChuiHW
pushed a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit 2394a3c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #16 (comment)
Itooks like linter doesn't check the
.d.ts. The upstream file here doesn't have license and the linter doesn't complain:https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/9370b35e1979ec6953ff59ed78c8751e4f463750/front_end/global_typings/request_idle_callback.d.ts#L1
Adding ours to the list for clarity of intention.
Test plan
npm run check-lint(Ignore the unrelated files)
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.