Perf: add launch events #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2024
Closed
EdmondChuiHW
force-pushed
the
session-events
branch
from
1f30ce3 to
3e9c11c
Compare
This was referenced Mar 21, 2024
huntie
approved these changes
Mar 22, 2024
EdmondChuiHW
force-pushed
the
session-events
branch
from
3e9c11c to
19005bc
Compare
EdmondChuiHW
force-pushed
the
session-events
branch
from
19005bc to
7531536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TLDR: two basic events for launch time
Open source: no-op as perf metrics is only applicable for internal builds. See #16
Entrypoint.LoadingStarted: fired when entry point begins loadingDebugger.IsReadyToPause: fired when SDK is ready to pauseCorresponding internal diff
Stack
Stacked on #26 and #27
Preview this PR in isolation at https://github.com/EdmondChuiHW/rn-chrome-devtools-frontend2/pull/2/files
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.