Skip to content

Conversation

@EdmondChuiHW
Copy link

Summary

  1. Refactor perf to remove global var. Previously mentioned in Perf: add support for launch ID #27 (comment) with @huntie
  2. Move perf calls to top for accurate timing measurements; added comments for future contributors

Stacked on #66. Please see e7260f7 for changes in this PR

Test plan

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@EdmondChuiHW EdmondChuiHW merged commit 8f28e69 into facebook:main May 20, 2024
@EdmondChuiHW EdmondChuiHW deleted the refactor-perf branch May 20, 2024 20:19
@motiz88
Copy link

motiz88 commented May 21, 2024

Refactor perf

Nit: Please try to write more meaningful commit titles/messages in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants