Added the accessibilityLanguage prop documentation#2970
Merged
Simek merged 7 commits intoMar 30, 2022
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Simek
added
🕐 Waiting on PR
|
LGTM, but I think we need to add documentation on Accessibility Properties. Because components that use accessibility actually extend AccessibilityProps to avoid redundancy and developers can also focus on learning about accessibility on the same page. |
iamrestrepo
reviewed
Mar 22, 2022
|
|
||
| ### `accessibilityLanguage` <div class="label ios">iOS</div> | ||
|
|
||
| Using the `accessibilityLanguage` property the screen reader will understand which language to use while reading the element's **label**, **value** and **hint**. The provided string value must follow the [BCP 47 specification](https://www.rfc-editor.org/info/bcp47). |
There was a problem hiding this comment.
By using the accessibilityLanguage property, the screen reader will ...
^^ I think it will make the sentence easy to read. 😃
Contributor
Author
There was a problem hiding this comment.
I like it, thank you! 🙂 Added here: 56f6f28
iamrestrepo
reviewed
Mar 22, 2022
iamrestrepo
left a comment
iamrestrepo
left a comment
There was a problem hiding this comment.
LGTM to me as well. Just a small suggestion on the accessibility.md file.
Simek
removed
the
🕐 Waiting on PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is going to add the
accessibilityLanguageprop documentation to all the components targeted by the changes of facebook/react-native#33090.I'm not a native english speaker so I'm open to improvements / changes 🙂