Integrated iOS-only `accessibilityLanguage` prop by dgopsq · Pull Request #33090 · facebook/react-native

dgopsq · 2022-02-11T11:02:37Z

Summary

This PR fixes #30891

This PR is going to add an accessibilityLanguage prop to all the available components. This props is currently working only on iOS and should follow the guidelines of the relative configuration.

I'm in no way an expert on native programming (especially Objective-C) so I'm open to changes / improvements 🙂

Changelog

[iOS] [Added] - Integrated the accessibilityLanguage prop to all the available components. The prop is available for any platform but it will work only on iOS.

Test Plan

This has been tested using both the Simulator, checking for the Language attribute, and using a physical device with the Voice Over enabled.

analysis-bot · 2022-02-11T11:33:08Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 46bc521
Branch: main

analysis-bot · 2022-02-11T11:39:02Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,187,593	-16,787
android	hermes	armeabi-v7a	7,789,339	-23,307
android	hermes	x86	8,558,375	-17,774
android	hermes	x86_64	8,510,871	-15,991
android	jsc	arm64-v8a	9,856,505	-16,789
android	jsc	armeabi-v7a	8,842,794	-23,310
android	jsc	x86	9,823,391	-17,766
android	jsc	x86_64	10,420,006	-15,989

Base commit: 46bc521
Branch: main

robhogan

Hi @dgopsq and thanks for the PR - this is a great first contribution!

I think we should add a platform hint to the comments to indicate that it's only implemented in iOS, and a docs PR would also be great, but this looks on the right track to me.

Co-authored-by: Rob Hogan <rh389@users.noreply.github.com>

dgopsq · 2022-02-11T20:34:11Z

Hi @dgopsq and thanks for the PR - this is a great first contribution!

I think we should add a platform hint to the comments to indicate that it's only implemented in iOS, and a docs PR would also be great, but this looks on the right track to me.

Thank you @rh389! A PR for the docs will follow soon 🙂

PrayaAmadigaPitasa

need documentation for new props

dgopsq · 2022-02-15T17:07:37Z

@PrayaAmadigaPitasa I've been a bit busy, in the next days I'll open the PR 🙂

By the way, I just noticed that the latest tests didn't pass on the CI but I cannot reproduce anything locally, and I don't think I'm seeing useful informations about the error, do you know what's the matter?

dgopsq · 2022-02-16T20:37:15Z

I opened facebook/react-native-website#2970 to address the documentation!

dgopsq · 2022-02-28T14:17:05Z

@rh389 @PrayaAmadigaPitasa Hello, sorry in advance for the notification, I just wanted to know if something else needs to be done on my part, if so let me know 🙂

facebook-github-bot · 2022-02-28T16:48:26Z

@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

robhogan · 2022-02-28T16:51:20Z

Thanks @dgopsq, sorry for the delay. This looks good to me - imported for final review

facebook-github-bot · 2022-03-01T14:35:54Z

@rh389 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-03-07T18:25:05Z

This pull request was successfully merged by @dgopsq in 7b05b09.

^{When will my fix make it into a release? | Upcoming Releases}

dvijeniii05 · 2022-07-15T15:35:11Z

Hi everyone!
I have a strange issue, where none of default React Native elements, such as View, Text, Touchable etc, they don't list accessibilityLanguage as a prop. None of them. Every other accessibility prop is available except Language.

Currently tried on 3 different "machines", 3 different projects, even a new one out of the box, and nothing.
Is there an issue with it? has the prop been removed?

gaurav5430 · 2022-07-19T09:57:42Z

Hi everyone! I have a strange issue, where none of default React Native elements, such as View, Text, Touchable etc, they don't list accessibilityLanguage as a prop. None of them. Every other accessibility prop is available except Language.

Currently tried on 3 different "machines", 3 different projects, even a new one out of the box, and nothing. Is there an issue with it? has the prop been removed?

I have the same problem, is it something to do with react native version?

gaurav5430 · 2022-07-19T09:59:46Z

@dgopsq how do you get the Advanced panel in accessibility inspector ?

gaurav5430 · 2022-07-19T10:22:43Z

Hi everyone! I have a strange issue, where none of default React Native elements, such as View, Text, Touchable etc, they don't list accessibilityLanguage as a prop. None of them. Every other accessibility prop is available except Language.
Currently tried on 3 different "machines", 3 different projects, even a new one out of the box, and nothing. Is there an issue with it? has the prop been removed?

I have the same problem, is it something to do with react native version?

As i can see, this is available from version 69 onwards. I am still on 68

dgopsq · 2022-07-26T19:21:14Z

@dgopsq how do you get the Advanced panel in accessibility inspector ?

@gaurav5430 I didn't do anything special, I just had it from the start. As far as I can see it's not even possible to hide it so you should have it too! 🤔

Hi everyone! I have a strange issue, where none of default React Native elements, such as View, Text, Touchable etc, they don't list accessibilityLanguage as a prop. None of them. Every other accessibility prop is available except Language.

Currently tried on 3 different "machines", 3 different projects, even a new one out of the box, and nothing. Is there an issue with it? has the prop been removed?

@dvijeniii05 You're using TypeScript right? I just noticed that @types/react-native doesn't have the accessibilityLanguage prop. I'll try to make a PR as soon as possible 🙂

Summary: This PR fixes facebook#30891 This PR is going to add an `accessibilityLanguage` prop to all the available components. This props is currently working only on iOS and should follow the [guidelines of the relative configuration](https://developer.apple.com/documentation/objectivec/nsobject/1615192-accessibilitylanguage). I'm in no way an expert on native programming (especially Objective-C) so I'm open to changes / improvements 🙂  [iOS] [Added] - Integrated the `accessibilityLanguage` prop to all the available components. The prop is available for any platform but it will work only on iOS. Pull Request resolved: facebook#33090 Test Plan: This has been tested using both the Simulator, checking for the `Language` attribute, and using a physical device with the Voice Over enabled. <img width="1083" alt="Screenshot 2022-02-11 at 13 17 32" src="https://user-images.githubusercontent.com/5963683/153590415-65fcb4ff-8f31-4a0f-90e5-8eb1aae6aa3d.png"> Reviewed By: philIip Differential Revision: D34523608 Pulled By: rh389 fbshipit-source-id: b5d77fc0b3d76ea8ed8f30c8385459ba98122ff6

dgopsq added 11 commits January 28, 2022 23:55

Created accessibilityLanguage bridge

d32e99b

Added accessibilityLanguage to the touchables components

810d328

Added accessibilityLanguage to Pressable

495a831

Added accessibilityLanguage to Button

982dc42

Added accessibilityLanguage to Text

08bbf48

Implemented accessibilityLanguage for the text native element

3676a26

Added accessibilityLanguage doc comment

e2281b9

Merge branch 'main' into feature/created-accessibility-language-bridge

f262584

Added accessibilityLanguage valid prop into PlatformBaseViewConfig

834c79f

Merge branch 'main' into feature/created-accessibility-language-bridge

9b74b3d

Added AccessibilityIOSExample example

70efd3b

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 11, 2022

react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Feb 11, 2022

Set the accessibilityLanguage on the View in the example

7aa41d6

dgopsq marked this pull request as ready for review February 11, 2022 12:57

facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Feb 11, 2022

robhogan reviewed Feb 11, 2022

View reviewed changes

Comment thread Libraries/Components/View/ViewPropTypes.js

Added platform specific hint "ios"

073fccc

Co-authored-by: Rob Hogan <rh389@users.noreply.github.com>

PrayaAmadigaPitasa reviewed Feb 15, 2022

View reviewed changes

dgopsq mentioned this pull request Feb 16, 2022

Added the accessibilityLanguage prop documentation facebook/react-native-website#2970

Merged

Merge branch 'main' into feature/created-accessibility-language-bridge

6fe75ea

clang-format

f88caba

facebook-github-bot closed this in 7b05b09 Mar 7, 2022

react-native-bot added the Merged This PR has been merged. label Mar 7, 2022

Conversation

dgopsq commented Feb 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Test Plan

Uh oh!

analysis-bot commented Feb 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

analysis-bot commented Feb 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robhogan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dgopsq commented Feb 11, 2022

Uh oh!

PrayaAmadigaPitasa left a comment

Choose a reason for hiding this comment

Uh oh!

dgopsq commented Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dgopsq commented Feb 16, 2022

Uh oh!

dgopsq commented Feb 28, 2022

Uh oh!

facebook-github-bot commented Feb 28, 2022

Uh oh!

robhogan commented Feb 28, 2022

Uh oh!

facebook-github-bot commented Mar 1, 2022

Uh oh!

react-native-bot commented Mar 7, 2022

Uh oh!

dvijeniii05 commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaurav5430 commented Jul 19, 2022

Uh oh!

gaurav5430 commented Jul 19, 2022

Uh oh!

gaurav5430 commented Jul 19, 2022

Uh oh!

dgopsq commented Jul 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dgopsq commented Feb 11, 2022 •

edited

Loading

analysis-bot commented Feb 11, 2022 •

edited

Loading

analysis-bot commented Feb 11, 2022 •

edited

Loading

dgopsq commented Feb 15, 2022 •

edited

Loading

dvijeniii05 commented Jul 15, 2022 •

edited

Loading