Skip to content

Accessibility Escape#655

Merged
hramos merged 1 commit intofacebook:masterfrom
rustle:master
Feb 26, 2019
Merged

Accessibility Escape#655
hramos merged 1 commit intofacebook:masterfrom
rustle:master

Conversation

@rustle
Copy link
Copy Markdown
Contributor

@rustle rustle commented Oct 31, 2018

Documentation updates related to facebook/react-native#22047

@react-native-bot
Copy link
Copy Markdown

Deploy preview for react-native ready!

Built with commit 1f5741e

https://deploy-preview-655--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@hramos hramos added the 🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged label Nov 2, 2018
Copy link
Copy Markdown

@estevaolucas estevaolucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it!

I was missing other a11y features on RN (like reduce motion). Your PR is inspiring me to make the same: contribute with RN in order to have a better accessibility support on React Native.

Comment thread docs/view.md

When `accessible` is `true`, the system will invoke this function when the user performs the escape gesture.

| Type | Required |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Platform column is also needed here, right? with an iOS for its value, same as accessibilitytraits

@hramos hramos merged commit 1cd1ce9 into facebook:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🕐 Waiting on PR These may be waiting for a PR to the facebook/react-native to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants