resizeMode `cover` doesn't scale up images

[etodanik]

Description

resizeMode cover is supposed to make the image width and/or height the same size or bigger than the containing view so that the image fully covers the area of the view.

Currently that only happens if the image is too big. A small image is not being rescaled properly.

Reproduction

Testing was done with network images.

Suppose we're trying to display a 200x200 image to cover a 250x250 View. The current logic would only scale the image down if necessary, and since in that case it isn't - it would end up causing the image to have white borders.

Solution

Scale image up if resizeMode is cover and image is smaller than the View size we're trying to fill.

Additional Information

• React Native version: 0.39
• Platform: both ios & android

[ptmt]

@israelidanny Is there any particular reason why did you close it?

[etodanik]

@ptmt after further testing, I found out that for some weird reason the images I was working with (straight out of Instagram API) had weird borders and white areas in them in certain cases, which I initially mistook for borders created by RN (initially making the wrong assumption that the network images I'm getting are intact)

I looked at the code in RN and in fact there is code that scales both up and down (the scaling is done based on ratio).

So it seems the problem wasn't in react-native but rather in the images I was working with that came out of IG API