Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
Hey @ericlewis, could you email me at cpojer@fb.com so I can invite you to our contributors Discord channel? :) |
Contributor
Author
|
Sure! Also, I enabled the test here. But not sure if in correct part of CircleCI config. |
cpojer
approved these changes
Feb 21, 2019
Contributor
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
Cool, seems it is passing, so let's land it.
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 21, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
This may also work for Android, I didn’t turn on the test though. The resolution was to ensure we got a react-native-cli to use, so it might work! |
Collaborator
|
@ericlewis merged commit 4a01be4 into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: As part of facebook#23561 this is an attempt at fixing iOS. [iOS] [Fixed] - e2e test Pull Request resolved: facebook#23566 Differential Revision: D14162780 Pulled By: cpojer fbshipit-source-id: b55d32e30f88370100f7fbddf9dfb208280844f4
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of #23561 this is an attempt at fixing iOS.
Changelog
[iOS] [Fixed] - e2e test
Test Plan
run
node ./scripts/run-ci-e2e-tests.js --ios