[iOS] Inconsistent behaviour when converting homogeneous arrays as native call arguments

[gavrix]

On iOS, when calling native method that accepts array as argument, automatic conversion of values inside array is different in Release and Debug configuration. What works in Debug crashes in Release

React Native version:
React Native Environment Info:
System:
OS: macOS 10.14.5
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 663.40 MB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 10.11.0 - ~/.nvm/versions/node/v10.11.0/bin/node
Yarn: 1.13.0 - ~/.dev/yarn/1.13.0/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v10.11.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
IDEs:
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.8 => 0.59.8

Steps To Reproduce

Call AsyncStorage.set('key', 123)
Above works in Debug and crashes in Release

Describe what you expected to happen:

Above works in debug as number (although types suggest it explicitly expects string) gets automatically converted to string via sequence of calls ending with RCTConvertArrayValue which converts converts anything to expected type (which is NSString)

react-native/React/Base/RCTConvert.m

Line 558 in ffa3b0d

NSArray *RCTConvertArrayValue(SEL type, id json)

in Release sequence of macro calls is different though, never reaching RCTConvertArrayValue as can be seen here

react-native/React/Base/RCTConvert.m

Lines 591 to 596 in ffa3b0d

	#if RCT_DEBUG
	#define RCT_JSON_ARRAY_CONVERTER_NAMED(type, name) RCT_ARRAY_CONVERTER_NAMED(type, name)
	#else
	#define RCT_JSON_ARRAY_CONVERTER_NAMED(type, name) + (NSArray *)name##Array:(id)json { return json; }
	#endif
	#define RCT_JSON_ARRAY_CONVERTER(type) RCT_JSON_ARRAY_CONVERTER_NAMED(type, type)

What I think is expected behaviour is that in Debug it should log error descriptions of types mismatches but never convert anything to NSString automatically.

Were there any considerations as to why automatic conversion to string was added that I am missing?

[cpojer]

Please report issues in AsyncStorage in this repo: https://github.com/react-native-community/async-storage – it was extracted from RN and will soon be removed from React Native. Please use the community package from now on.

[gavrix]

@cpojer, please, read carefully. The issue is in React Native RUNTIME. I only used AsyncStorage to illustrate it. It could have been any other native module with method that accepts array of strings as parameter.

[sammy-SC]

@gavrix this should resolved in df17ebf

[gavrix]

Awesome, Thanks!

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[stale]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.