Adding missing #import <QuartzCore/QuartzCore.h> imports#35315
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Adding missing #import <QuartzCore/QuartzCore.h> imports#35315christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41229835 |
Base commit: f657d29 |
Base commit: f657d29 |
|
PR build artifact for bbaa4e88d84eaf452448f03a2c975f4dc442fb84 is ready. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41229835 |
christophpurrer
force-pushed
the
export-D41229835
branch
from
bbaa4e8 to
de27eff
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41229835 |
christophpurrer
force-pushed
the
export-D41229835
branch
from
de27eff to
d957ae4
Compare
|
PR build artifact for d957ae4aa4557600843beaf495c95e54bece516c is ready. |
) Summary: Pull Request resolved: facebook#35315 These headers are needed on react-native-macOS, but not explicitly imported all the time. It seems that some UIKit header will implicitly import them. Changelog: [Internal] Differential Revision: D41229835 fbshipit-source-id: d7ca2b1abd9f63c2d93df1bca56108401ea2f814
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41229835 |
christophpurrer
force-pushed
the
export-D41229835
branch
from
d957ae4 to
53d6daa
Compare
|
PR build artifact for 53d6daa is ready. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 14, 2022
) Summary: Pull Request resolved: facebook#35315 These headers are needed on react-native-macOS, but not explicitly imported all the time. It seems that some UIKit header will implicitly import them. We have other use case in react-native(-iOS) in which we also explicitly importing them - https://github.com/facebook/react-native/search?q=QuartzCore- , hence use following 'that' practice 'here'. Changelog: [Internal] Reviewed By: javache Differential Revision: D41229835 fbshipit-source-id: b0182bf4f7905e8e157b341eb62cadec6ba354ca # Conflicts: # Libraries/Text/Text/RCTTextView.m # React/Views/RCTView.m
Saadnajmi
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Nov 15, 2022
) (#1507) Summary: Pull Request resolved: facebook#35315 These headers are needed on react-native-macOS, but not explicitly imported all the time. It seems that some UIKit header will implicitly import them. We have other use case in react-native(-iOS) in which we also explicitly importing them - https://github.com/facebook/react-native/search?q=QuartzCore- , hence use following 'that' practice 'here'. Changelog: [Internal] Reviewed By: javache Differential Revision: D41229835 fbshipit-source-id: b0182bf4f7905e8e157b341eb62cadec6ba354ca # Conflicts: # Libraries/Text/Text/RCTTextView.m # React/Views/RCTView.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
These headers are needed on react-native-macOS, but not explicitly imported all the time. It seems that some UIKit header will implicitly import them.
Changelog: [Internal]
Differential Revision: D41229835