Cherry-pick: Adding missing #import <QuartzCore/QuartzCore.h> imports (#35315)#1507
Merged
Saadnajmi merged 1 commit intomicrosoft:mainfrom Nov 15, 2022
Merged
Cherry-pick: Adding missing #import <QuartzCore/QuartzCore.h> imports (#35315)#1507Saadnajmi merged 1 commit intomicrosoft:mainfrom
Saadnajmi merged 1 commit intomicrosoft:mainfrom
Conversation
) Summary: Pull Request resolved: facebook#35315 These headers are needed on react-native-macOS, but not explicitly imported all the time. It seems that some UIKit header will implicitly import them. We have other use case in react-native(-iOS) in which we also explicitly importing them - https://github.com/facebook/react-native/search?q=QuartzCore- , hence use following 'that' practice 'here'. Changelog: [Internal] Reviewed By: javache Differential Revision: D41229835 fbshipit-source-id: b0182bf4f7905e8e157b341eb62cadec6ba354ca # Conflicts: # Libraries/Text/Text/RCTTextView.m # React/Views/RCTView.m
Saadnajmi
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
A cherry-pick from facebook/react-native@0.72:
facebook@c0f06e8
These headers are needed on react-native-macOS, but not explicitly imported all the time.
It seems that some UIKit header will implicitly import them.
We have other use case in react-native(-iOS) in which we also explicitly importing them - https://github.com/facebook/react-native/search?q=QuartzCore- , hence use following 'that' practice 'here'.
Changelog
Changelog: [Internal]
Test Plan
Run rn-tester-macOS:
