Skip to content

[0.76] Add CLI selection of multiple debug targets#46644

Merged
blakef merged 2 commits intofacebook:0.76-stablefrom
huntie:0.76-debug-cli-selection-1
Sep 30, 2024
Merged

[0.76] Add CLI selection of multiple debug targets#46644
blakef merged 2 commits intofacebook:0.76-stablefrom
huntie:0.76-debug-cli-selection-1

Conversation

@huntie
Copy link
Copy Markdown
Member

@huntie huntie commented Sep 25, 2024

Summary

Note

Depends on #46643.

This is a 0.76 pick (eager) of #46627. We're blocked from landing that PR on main first, as Metro is not yet released targeting main (we're in a temporary state with alpha releases for 0.76).

Introduces a target selection API for launching React Native DevTools when more than one device is connected.

Credit to @robhogan for the initial internal implementation of OpenDebuggerKeyboardHandler!

(This leverages recent additions to Metro's reporter API — which we should follow up on to use for the rest of community-cli-plugin. Notably, using TerminalReporter ensures server output won't conflict with Metro's own event and progress logs.)

Changelog: [Internal]

Test Plan

See next PR.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 25, 2024
@huntie huntie changed the title Update Metro to 0.81.0-alpha.2 [0.76] Add CLI selection of multiple debug targets Sep 25, 2024
@react-native-bot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 62f04bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants