Skip to content

[0.76] Use Metro terminal reporter for dev-middleware logs#46646

Merged
blakef merged 4 commits intofacebook:0.76-stablefrom
huntie:0.76-align-devserver-logs
Sep 30, 2024
Merged

[0.76] Use Metro terminal reporter for dev-middleware logs#46646
blakef merged 4 commits intofacebook:0.76-stablefrom
huntie:0.76-align-devserver-logs

Conversation

@huntie
Copy link
Copy Markdown
Member

@huntie huntie commented Sep 25, 2024

Summary

Note

Depends on #46643, #46644, and #46645. Final change towards this JS-only feature.

This is a reduced version of D63328268 targeting 0.76-stable, and is the final piece of debugger target selection in the CLI.

I'd originally not planned to pick this change (as not using Metro's reporter keeps the previous status quo), but not doing so leads to a very obvious piece of visual jank when using j to debug — see test plan.

Changelog: [Internal]

Test Plan

Before After
image image

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 25, 2024
@react-native-bot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 6382dc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants