android compileSdk 26, build-tools 26.0.2#19531
Closed
dulmandakh wants to merge 10 commits intofacebook:masterfrom
Closed
android compileSdk 26, build-tools 26.0.2#19531dulmandakh wants to merge 10 commits intofacebook:masterfrom
dulmandakh wants to merge 10 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
Also, please merge #19325 that will make gradle builds much faster |
react-native-bot
added
Missing Test Plan
Contributor
Author
|
once merged, we can add more features to Android that makes developers life easier like custom fonts 😄 and utilize Android Lifecycle for better and robust application, activity and fragment lifecycle handling. |
Contributor
|
I think put them in one pr is more clear, any thought ? Also the rebase this pr to pass the ci, android ci fixed in master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses android build tools 26.0.2, support library 26.1.0 (with android lifecycle) and setting compileSdkVersion to 26, but leaving minSdkVersion and targetSdkVersion intact.
CI builds just fine, but having error with bundling JS or same error as master.
Sorry, that I messed up with PR git history 😄
@hramos