clean buck binary_jar warnings

ReactAndroid/src/main/libraries/fbcore/src/test/java/com/facebook/powermock/BUCK

@@ -21,144 +21,144 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "powermock-core",
-    binary_jar = ":download-powermock-core",
+    binary_jar = ":download-powermock-core.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-powermock-core",
+    name = "download-powermock-core.jar",
     sha1 = "ea04e79244e19dcf0c3ccf6863c5b028b4b58c9c",
     url = "mvn:org.powermock:powermock-core:jar:1.6.2",
 )
 
 rn_prebuilt_jar(
     name = "powermock-api-mockito",
-    binary_jar = ":download-powermock-api-mockito",
+    binary_jar = ":download-powermock-api-mockito.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-powermock-api-mockito",
+    name = "download-powermock-api-mockito.jar",
     sha1 = "c213230ae20a7b422f3d622a261d0e3427d2464c",
     url = "mvn:org.powermock:powermock-api-mockito:jar:1.6.2",
 )
 
 rn_prebuilt_jar(
     name = "powermock-api-support",
-    binary_jar = ":download-powermock-api-support",
+    binary_jar = ":download-powermock-api-support.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-powermock-api-support",
+    name = "download-powermock-api-support.jar",
     sha1 = "93b21413b4ee99b7bc0dd34e1416fdca96866aaf",
     url = "mvn:org.powermock:powermock-api-support:jar:1.6.2",
 )
 
 rn_prebuilt_jar(
     name = "powermock-module-junit4-rule",
-    binary_jar = ":download-powermock-module-junit4-rule",
+    binary_jar = ":download-powermock-module-junit4-rule.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-powermock-module-junit4-rule",
+    name = "download-powermock-module-junit4-rule.jar",
     sha1 = "4847638c5729b9f203e21144b0bdb5d34d888473",
     url = "mvn:org.powermock:powermock-module-junit4-rule:jar:1.6.2",
 )
 
 rn_prebuilt_jar(
     name = "powermock-classloading-xstream",
-    binary_jar = ":download-powermock-classloading-xstream",
+    binary_jar = ":download-powermock-classloading-xstream.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-powermock-classloading-xstream",
+    name = "download-powermock-classloading-xstream.jar",
     sha1 = "3ced31cd7024fe365b9f3c8082d22c02434577da",
     url = "mvn:org.powermock:powermock-classloading-xstream:jar:1.6.2",
 )
 
 rn_prebuilt_jar(
     name = "powermock-classloading-base",
-    binary_jar = ":download-powermock-classloading-base",
+    binary_jar = ":download-powermock-classloading-base.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-powermock-classloading-base",
+    name = "download-powermock-classloading-base.jar",
     sha1 = "c8bfc10731a02d3b241892cf2c334a754d473ca7",
     url = "mvn:org.powermock:powermock-classloading-base:jar:1.6.2",
 )
 
 rn_prebuilt_jar(
     name = "xstream",
-    binary_jar = ":download-xstream",
+    binary_jar = ":download-xstream.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-xstream",
+    name = "download-xstream.jar",
     sha1 = "97e5013f391487cce4de6b0eebcde21549e91872",
     url = "mvn:com.thoughtworks.xstream:xstream:jar:1.4.2",
 )
 
 rn_prebuilt_jar(
     name = "powermock-reflect",
-    binary_jar = ":download-powermock-reflect",
+    binary_jar = ":download-powermock-reflect.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-powermock-reflect",
+    name = "download-powermock-reflect.jar",
     sha1 = "1af1bbd1207c3ecdcf64973e6f9d57dcd17cc145",
     url = "mvn:org.powermock:powermock-reflect:jar:1.6.2",
 )
 
 rn_prebuilt_jar(
     name = "javassist",
-    binary_jar = ":download-javassist",
+    binary_jar = ":download-javassist.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-javassist",
+    name = "download-javassist.jar",
     sha1 = "a9cbcdfb7e9f86fbc74d3afae65f2248bfbf82a0",
     url = "mvn:org.javassist:javassist:jar:3.20.0-GA",
 )
 
 rn_prebuilt_jar(
     name = "mockito-all",
-    binary_jar = ":download-mockito-all",
+    binary_jar = ":download-mockito-all.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-mockito-all",
+    name = "download-mockito-all.jar",
     sha1 = "539df70269cc254a58cccc5d8e43286b4a73bf30",
     url = "mvn:org.mockito:mockito-all:jar:1.10.19",
 )
 
 rn_prebuilt_jar(
     name = "xmlpull",
-    binary_jar = ":download-xmlpull",
+    binary_jar = ":download-xmlpull.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-xmlpull",
+    name = "download-xmlpull.jar",
     sha1 = "2b8e230d2ab644e4ecaa94db7cdedbc40c805dfa",
     url = "mvn:xmlpull:xmlpull:jar:1.1.3.1",
 )
 
 rn_prebuilt_jar(
     name = "xpp3",
-    binary_jar = ":download-xpp3",
+    binary_jar = ":download-xpp3.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-xpp3",
+    name = "download-xpp3.jar",
     sha1 = "19d4e90b43059058f6e056f794f0ea4030d60b86",
     url = "mvn:xpp3:xpp3_min:jar:1.1.4c",
 )

ReactAndroid/src/main/libraries/fresco/fresco-react-native/BUCK

@@ -60,12 +60,12 @@ remote_file(
 
 rn_prebuilt_jar(
     name = "bolts",
-    binary_jar = ":download-bolts",
+    binary_jar = ":download-bolts.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-bolts",
+    name = "download-bolts.jar",
     sha1 = "d85884acf6810a3bbbecb587f239005cbc846dc4",
     url = "mvn:com.parse.bolts:bolts-tasks:jar:1.4.0",
 )

ReactAndroid/src/main/libraries/textlayoutbuilder/BUCK

@@ -23,12 +23,12 @@ remote_file(
 
 rn_prebuilt_jar(
     name = "staticlayoutproxy",
-    binary_jar = ":staticlayoutproxy-jar",
+    binary_jar = ":staticlayoutproxy.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "staticlayoutproxy-jar",
+    name = "staticlayoutproxy.jar",
     sha1 = "f162442a19fff13995fbd51ba414d9ee05579080",
     url = "mvn:com.facebook.fbui.textlayoutbuilder:staticlayout-proxy:jar:1.0",
 )

ReactAndroid/src/main/third-party/android/support-annotations/BUCK

@@ -1,11 +1,11 @@
 prebuilt_jar(
     name = "android-support-annotations",
-    binary_jar = ":support-annotations-binary-aar",
+    binary_jar = ":support-annotations-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "support-annotations-binary-aar",
+    name = "support-annotations-binary.jar",
     sha1 = "0814258103cf26a15fcc26ecce35f5b7d24b73f8",
     url = "mvn:com.android.support:support-annotations:jar:26.1.0",
 )

ReactAndroid/src/main/third-party/android/support/v4/BUCK

@@ -7,20 +7,20 @@ android_library(
       ":lib-support-v4-support-media-compat",
       ":lib-support-v4-support-fragment",
       ":android-lifecycle-runtime",
-      ":android-lifecycle-common.jar",
-      ":android-lifecycle-core.jar"
+      ":android-lifecycle-common",
+      ":android-lifecycle-core"
     ],
     visibility = ["PUBLIC"],
 )
 
 prebuilt_jar(
-    name = "android-lifecycle-common.jar",
-    binary_jar = ":android-lifecycle-common-jar"
+    name = "android-lifecycle-common",
+    binary_jar = ":android-lifecycle-common.jar"
 )
 
 prebuilt_jar(
-    name = "android-lifecycle-core.jar",
-    binary_jar = ":android-lifecycle-core-jar"
+    name = "android-lifecycle-core",
+    binary_jar = ":android-lifecycle-core.jar"
 )
 
 android_prebuilt_aar(
@@ -60,13 +60,13 @@ remote_file(
 )
 
 remote_file(
-  name = "android-lifecycle-common-jar",
+  name = "android-lifecycle-common.jar",
   sha1 = "e414a4cb28434e25c4f6aa71426eb20cf4874ae9",
   url = "mvn:android.arch.lifecycle:common:jar:1.0.0"
 )
 
 remote_file(
-  name = "android-lifecycle-core-jar",
+  name = "android-lifecycle-core.jar",
   sha1 = "a2d487452376193fc8c103dd2b9bd5f2b1b44563",
   url = "mvn:android.arch.core:common:jar:1.0.0"
 )
@@ -99,4 +99,4 @@ remote_file(
   name = "lib-support-v4-support-fragment-aar",
   sha1 = "ddacf369bb98dd6558606558de8ddcd53895cf91",
   url = "mvn:com.android.support:support-fragment:aar:26.1.0",
-)
+)

ReactAndroid/src/main/third-party/java/asm/BUCK

@@ -14,60 +14,60 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "asm-core",
-    binary_jar = ":download-asm",
+    binary_jar = ":download-asm.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm",
+    name = "download-asm.jar",
     sha1 = "2fd56467a018aafe6ec6a73ccba520be4a7e1565",
     url = "mvn:org.ow2.asm:asm:jar:5.0.1",
 )
 
 rn_prebuilt_jar(
     name = "asm-commons",
-    binary_jar = ":download-asm-commons",
+    binary_jar = ":download-asm-commons.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm-commons",
+    name = "download-asm-commons.jar",
     sha1 = "7b7147a390a93a14d2edfdcf3f7b0e87a0939c3e",
     url = "mvn:org.ow2.asm:asm-commons:jar:5.0.1",
 )
 
 rn_prebuilt_jar(
     name = "asm-tree",
-    binary_jar = ":download-asm-tree",
+    binary_jar = ":download-asm-tree.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm-tree",
+    name = "download-asm-tree.jar",
     sha1 = "1b1e6e9d869acd704056d0a4223071a511c619e6",
     url = "mvn:org.ow2.asm:asm-tree:jar:5.0.1",
 )
 
 rn_prebuilt_jar(
     name = "asm-util",
-    binary_jar = ":download-asm-util",
+    binary_jar = ":download-asm-util.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm-util",
+    name = "download-asm-util.jar",
     sha1 = "7c8caddfbd0b2d7b844f8fcc75175b9cb9cf4724",
     url = "mvn:org.ow2.asm:asm-util:jar:5.0.1",
 )
 
 rn_prebuilt_jar(
     name = "asm-analysis",
-    binary_jar = ":download-asm-analysis",
+    binary_jar = ":download-asm-analysis.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm-analysis",
+    name = "download-asm-analysis.jar",
     sha1 = "e286fbee48efacb4e7c175f7948d9d8b2ab52352",
     url = "mvn:org.ow2.asm:asm-analysis:jar:5.0.1",
 )

ReactAndroid/src/main/third-party/java/fest/BUCK

@@ -11,24 +11,24 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "fest-core",
-    binary_jar = ":fest-binary-jar",
+    binary_jar = ":fest-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "fest-binary-jar",
+    name = "fest-binary.jar",
     sha1 = "cb7c91cf614901928ae405f19d9bcdedf82781db",
     url = "mvn:org.easytesting:fest-assert-core:jar:2.0M10",
 )
 
 rn_prebuilt_jar(
     name = "fest-util",
-    binary_jar = ":fest-util-binary-jar",
+    binary_jar = ":fest-util-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "fest-util-binary-jar",
+    name = "fest-util-binary.jar",
     sha1 = "c4a8d7305b23b8d043be12c979813b096df11f44",
     url = "mvn:org.easytesting:fest-util:jar:1.2.5",
 )

ReactAndroid/src/main/third-party/java/javapoet/BUCK

@@ -1,11 +1,11 @@
 prebuilt_jar(
     name = "javapoet",
-    binary_jar = ":jsr305-binary-jar",
+    binary_jar = ":jsr305-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "jsr305-binary-jar",
+    name = "jsr305-binary.jar",
     sha1 = "ad3ba65c1788f4d814a4da056323e2b84412fb3c",
     url = "mvn:com.squareup:javapoet:jar:1.2.0",
 )

ReactAndroid/src/main/third-party/java/jsr-305/BUCK

@@ -1,11 +1,11 @@
 prebuilt_jar(
     name = "jsr-305",
-    binary_jar = ":jsr305-binary-jar",
+    binary_jar = ":jsr305-binary.jar",
     visibility = ["PUBLIC"],
 )
 
 remote_file(
-    name = "jsr305-binary-jar",
+    name = "jsr305-binary.jar",
     sha1 = "5871fb60dc68d67da54a663c3fd636a10a532948",
     url = "mvn:com.google.code.findbugs:jsr305:jar:3.0.0",
 )