Skip to content

fix android ci#19881

Closed
dulmandakh wants to merge 1 commit intofacebook:masterfrom
dulmandakh:fix-buck-ci
Closed

fix android ci#19881
dulmandakh wants to merge 1 commit intofacebook:masterfrom
dulmandakh:fix-buck-ci

Conversation

@dulmandakh
Copy link
Copy Markdown
Contributor

@dulmandakh dulmandakh commented Jun 25, 2018 •
edited
Loading

This PR fixes buck and CI
CI: https://circleci.com/gh/dulmandakh/react-native/533

CC: @hramos

Test Plan:

CI is green again

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2018
@react-native-bot react-native-bot added ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Platform: Android Android applications. labels Jun 25, 2018
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jun 25, 2018
facebook-github-bot
facebook-github-bot approved these changes Jun 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos
Copy link
Copy Markdown
Contributor

hramos commented Jun 25, 2018

Thanks for the fix @dulmandakh. I just checked with the Buck team and they will push out a new Buck release that should include support for this feature. We probably will not need to apply this patch.

@hramos hramos mentioned this pull request Jun 25, 2018
Closed
@hramos
Copy link
Copy Markdown
Contributor

hramos commented Jun 25, 2018

Looks like the new Buck release does fix CI. Closing this PR in favor of #19882. Again, thanks for jumping on this quickly!

@hramos hramos closed this Jun 25, 2018
facebook-github-bot pushed a commit that referenced this pull request Jun 26, 2018
@hramos @facebook-github-bot
Bump Buck to v2018.06.25.01 (#19882)
86fb521 
Summary:
Fixes #19881
Closes #19882

Differential Revision: D8627994

Pulled By: hramos

fbshipit-source-id: ae43f2dd8dd5fac88590eeb4dddb18ebe5085359
@dulmandakh dulmandakh deleted the fix-buck-ci branch August 22, 2018 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Platform: Android Android applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dulmandakh @hramos @facebook-github-bot @react-native-bot