TextInput: Remove use of legacy context API #22220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
react-native-bot
added
🔶Components
Component: Text
Component: TextInput
RSNara
requested changes
Nov 16, 2018
Contributor
Author
|
It appears to be! Neither me or @TheSavior were able to find any uses for this. But he suggested that the removal of this be done as its own separate diff, in case there was dependant code that got looked over. |
RSNara
approved these changes
Dec 11, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@empyrical merged commit 94456ed into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of the legacy context API in
TextInput.Nothing in OSS appears to make use of the
focusEmitter.Test Plan:
Flow and ESLint has been ran. No regressions have been noticed in RNTester
Changelog:
[General] [Removed] - TextInput: Removed use of legacy context API