[CI] Pass Circle CI branch information to Coveralls#22489
Closed
hramos wants to merge 1 commit intofacebook:masterfrom
Closed
[CI] Pass Circle CI branch information to Coveralls#22489hramos wants to merge 1 commit intofacebook:masterfrom
hramos wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
hramos
force-pushed
the
coverage-branch
branch
from
5b6815c to
4b0748f
Compare
hramos
force-pushed
the
coverage-branch
branch
from
4b0748f to
d8771f7
Compare
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 3, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial. Coveralls expects CI_BRANCH to be set. Circle uses CIRCLE_BRANCH instead. Without this, Coverals will attribute coverage reports to a "patch-1" branch.