Remove persistence from RNTester app

[CodingItWrong]

Previously the RNTester app saved what screen you were on and what filter text was entered into the initial screen. This made e2e testing complex, as each test needed to manually restore the state to the home screen. If the state ever got out of sync with the test's expectations, it could lead to multiple failed tests.

There is still one specific component that uses persistence: RNTesterSettingSwitchRow. Persistence can be removed from this component next time tests for it are updated. As a result, RNTesterStatePersister is not yet entirely removed from the app.

Test Plan:

CI running yarn test-ios-e2e will confirm the tests still pass.

You can also run RNTester manually to confirm that after quitting and restarting the app, you're returned to the home screen of the app, and the filter state is not saved.

Changelog:

[General] [Removed] - Remove persistence from RNTester app

[elicwhite]

Looks like you have a flow error:

Error ----------------------------------------------------------------------------- RNTester/js/RNTesterApp.ios.js:119:9

Cannot create `RNTesterExampleList` element because property `searchTextInputStyle` is missing in props [1] but exists
in `Props` [2].

   RNTester/js/RNTesterApp.ios.js:119:9
                v-------------------
   119|         <RNTesterExampleList
   120|           onNavigate={this._handleAction}
   121|           list={RNTesterList}
   122|         />
                -^ [1]

References:
   RNTester/js/RNTesterExampleList.js:72:51
    72| class RNTesterExampleList extends React.Component<Props, $FlowFixMeState> {
                                                          ^^^^^ [2]

[CodingItWrong]

I'm not 100% sure if the above fix for the Flow error is correct. But I can't find anywhere the searchTextInputStyle was passed. So it seems like something about previously using RNTesterStatePersister was preventing Flow from erroring out although that prop was not passed. So the correct fix seems to be to remove the unused prop.

[CodingItWrong]

@TheSavior bump; passing now

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Looks good to me! Thanks for improving the RN test infra <3

[react-native-bot]

@CodingItWrong merged commit 33fb70f into facebook:master.