Fix failing Switch E2E tests#22698
Closed
CodingItWrong wants to merge 2 commits intofacebook:masterfrom
CodingItWrong:switch-e2e-flake
Closed
Fix failing Switch E2E tests#22698CodingItWrong wants to merge 2 commits intofacebook:masterfrom CodingItWrong:switch-e2e-flake
CodingItWrong wants to merge 2 commits intofacebook:masterfrom
CodingItWrong:switch-e2e-flake
Conversation
This is an attempt to prevent random failures of Switch tests
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Dec 18, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Member
|
This is sad, it more than doubles the time each test takes to run. |
Collaborator
|
@CodingItWrong merged commit bb09866 into |
grabbou
pushed a commit
that referenced
this pull request
Jan 3, 2019
Summary: Switch E2E tests have been failing on master, although they pass locally. Changelog: ---------- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. [General] [Fixed] - Fix failing Switch E2E tests Pull Request resolved: #22698 Differential Revision: D13511917 Pulled By: hramos fbshipit-source-id: b2f5cac1927531a855699e34e1a37036773f0aad
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Switch E2E tests have been failing on master, although they pass locally. Changelog: ---------- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. [General] [Fixed] - Fix failing Switch E2E tests Pull Request resolved: facebook#22698 Differential Revision: D13511917 Pulled By: hramos fbshipit-source-id: b2f5cac1927531a855699e34e1a37036773f0aad
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Switch E2E tests have been failing on master, although they pass locally. Changelog: ---------- Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example. [General] [Fixed] - Fix failing Switch E2E tests Pull Request resolved: facebook/react-native#22698 Differential Revision: D13511917 Pulled By: hramos fbshipit-source-id: b2f5cac1927531a855699e34e1a37036773f0aad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch E2E tests have been failing on master, although they pass locally.
Changelog:
Help reviewers and the release process by writing your own changelog entry. See http://facebook.github.io/react-native/docs/contributing#changelog for an example.
[General] [Fixed] - Fix failing Switch E2E tests
Test Plan:
Switch E2E tests should pass on CI