Fix crash in RNTester when removing/developing tests#23406
Closed
berickson1 wants to merge 1 commit intofacebook:masterfrom
Closed
Fix crash in RNTester when removing/developing tests#23406berickson1 wants to merge 1 commit intofacebook:masterfrom
berickson1 wants to merge 1 commit intofacebook:masterfrom
Conversation
Ensure that the current openExample (stored in AsyncStorage) exists in the module list. It's possible for the example to be missing if a test was removed & previously open in RNTester OR when actively developing RNTester tests & switching between branches
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 12, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@berickson1 merged commit da6a265 into |
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Ensure that the current openExample (stored in AsyncStorage) exists in the module list. It's possible for the example to be missing if a test was removed & previously open in RNTester OR when actively developing RNTester tests & switching between branches [General] [Fixed] - Potential crash in RNTester when removing/developing test cases Pull Request resolved: facebook/react-native#23406 Differential Revision: D14055695 Pulled By: cpojer fbshipit-source-id: 6cf00e097e934f7a342e7d210b6319e1cba142ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the current openExample (stored in AsyncStorage) exists in the module list.
Summary
It's possible for the example to be missing if a test was removed & previously open in RNTester OR when actively developing RNTester tests & switching between branches
Changelog
[General] [Fixed] - Potential crash in RNTester when removing/developing test cases
Test Plan