lock docker image version in ci

[gengjiawen]

Summary

Lock the version will help us to test new dependency version like ndk or buck.

Test Plan

pass current ci

[pull-bot]

	Messages
📖	📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS against f603ea5

[cpojer]

How often do you expect this image to change? Can we lock it to something that doesn't have a date in it? I'm not really sure if this is better than what we have now.

[dulmandakh]

IIRC, CI will try to pull images with latest tag from Docker registry and use it. And using this versioning scheme we can make sure that only working versions are used for CI, or prevent to use latest automatically.

[gengjiawen]

React native is very sophisticated project in my opinion, we may update it if jdk, node, buck or any other tools release new version.

You can check the image repo here: https://github.com/react-native-community/docker-android.

[dulmandakh]

@cpojer I expect that versions will be changed when we change tools versions, like JDK, SDK, NDK or BUCK.

[cpojer]

Alright, I trust you to keep it up to date :)

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[gengjiawen]

@cpojer If you want to involve the docker project, just let me know. I have talked to @hramos , but he has not reply my message.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[gengjiawen]

@cpojer should we import this again ?

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Yap! Seems like the import failed on the first try for some unknown reason.

[react-native-bot]

@gengjiawen merged commit 410d583 into facebook:master.