Allow compiler optimization#23536
Closed
ericlewis wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@ericlewis merged commit b0c69ab into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: Fixes a warning thrown by Xcode & allow RVO to be performed. [iOS] [Fixed] - Fix Xcode warnings Pull Request resolved: facebook#23536 Reviewed By: JoshuaGross Differential Revision: D14142973 Pulled By: hramos fbshipit-source-id: e23050aed811127a3b4f73aa8a74472e4cc8e98c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a warning thrown by Xcode & allow RVO to be performed.
Changelog
[iOS] [Fixed] - Fix Xcode warnings
Test Plan
Run and test.