Closed
Conversation
facebook-github-bot
added
CLA Signed
hramos
force-pushed
the
add-snapshots
branch
from
80ddf60 to
8bc5448
Compare
cpojer
approved these changes
Feb 20, 2019
Contributor
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
Yaay! Thank you for fixing this.
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 20, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: The iOS snapshots needed to be updated after facebook@cf5f254 updated `ViewExample.js`. [iOS] [Fixed] - Updated snapshots on iOS. Pull Request resolved: facebook#23538 Differential Revision: D14146723 Pulled By: cpojer fbshipit-source-id: f949d4c7925ab53ef42f42689bc2ed7b254dea48
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The iOS snapshots needed to be updated after cf5f254 updated
ViewExample.js.Changelog
[iOS] [Fixed] - Updated snapshots on iOS.
Test Plan
Generated on Xcode 10.1 using an iPhone 6s simulator.