Fix testScrollViewExample flakiness#23541
Closed
ericlewis wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@hramos it appears to be fixed. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 19, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@ericlewis merged commit d419f07 into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: Sometimes images are slow to load, and they are quite heavy. This converts the ScrollViewExample to a list of simple text items, similar to the append example inside of it. What it looks like: https://i.imgur.com/jt083Iv.png [iOS] [Fixed] - Fix testScrollViewExample flakiness Pull Request resolved: facebook#23541 Differential Revision: D14142947 Pulled By: hramos fbshipit-source-id: c897a4caa5374ef67e3d67306e3124c29b969565
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes images are slow to load, and they are quite heavy. This converts the ScrollViewExample to a list of simple text items, similar to the append example inside of it.
What it looks like: https://i.imgur.com/jt083Iv.png
Changelog
[iOS] [Fixed] - Fix testScrollViewExample flakiness
Test Plan
Run the tests.