[iOS] Fixed RNTester tvOS build error on Xcode10#23543
Closed
zhongwuzw wants to merge 1 commit intofacebook:masterfrom
Closed
[iOS] Fixed RNTester tvOS build error on Xcode10#23543zhongwuzw wants to merge 1 commit intofacebook:masterfrom
zhongwuzw wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Platform: iOS
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 20, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@zhongwuzw merged commit 9375a12 into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: We add info.plist into `Copy Bundle Resources`, it leads to build error on new Xcode10 compile system. [iOS] [fixed] - Fixed RNTester tvOS build error on Xcode10 Pull Request resolved: facebook#23543 Differential Revision: D14146488 Pulled By: cpojer fbshipit-source-id: 10d9973fadb7e79e76e6a2a4945c9108184e4708
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We add info.plist into
Copy Bundle Resources, it leads to build error on new Xcode10 compile system.Changelog
[iOS] [fixed] - Fixed RNTester tvOS build error on Xcode10
Test Plan
RNTester-tvOS build on Xcode10 successfully.