fix getPhotos params on RNTester XHR example.#23548
Closed
ericlewis wants to merge 2 commits intofacebook:masterfrom
Closed
fix getPhotos params on RNTester XHR example.#23548ericlewis wants to merge 2 commits intofacebook:masterfrom
ericlewis wants to merge 2 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
🌐Networking
Contributor
Author
|
this also fixes the iOS snapshots (yet again) |
Contributor
Author
|
@hramos, I noticed you are trying to update the screenshots- I have also done so on this PR & is passing. |
Contributor
|
Great, I’ll merge this once I’m back at my computer. Thank you! Sent with GitHawk |
Contributor
|
Sent with GitHawk |
Closed
hramos
approved these changes
Feb 20, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 20, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@ericlewis merged commit 38e91e6 into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: Fixes redscreen on RNTester's XHR page. CameraRoll getPhotos was missing params. ss: https://i.imgur.com/JLThyrF.png [iOS] [Fixed] - RNTester XHR Example crash Pull Request resolved: facebook#23548 Differential Revision: D14151304 Pulled By: hramos fbshipit-source-id: 7ff02c7fe32f09aecd50bc7df9f37b7cd2851b1c
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes redscreen on RNTester's XHR page. CameraRoll getPhotos was missing params.
ss: https://i.imgur.com/JLThyrF.png
Changelog
[iOS] [Fixed] - RNTester XHR Example crash
Test Plan
Run RN tester