[iOS] Add Image query cache result type#23608
Closed
zhongwuzw wants to merge 2 commits intofacebook:masterfrom
Closed
[iOS] Add Image query cache result type#23608zhongwuzw wants to merge 2 commits intofacebook:masterfrom
zhongwuzw wants to merge 2 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Component: Image
Platform: iOS
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 25, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @zhongwuzw in 5bc9c9b. When will my fix make it into a release? | Upcoming Releases |
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In iOS, seems we have no ways to check wether the cached item is from disk or memory, only
storagePolicy == NSURLCacheStorageAllowedInMemoryOnlywe can think it's from memory. So we need to add a new result likedisk/memory?Changelog
[iOS] [Added] - Add Image query cache result type
Test Plan
If we can't check cached item from disk or memory, return "disk/memory".