TM iOS: Remove retainArguments && do retain by us explicitly#24849
Closed
zhongwuzw wants to merge 1 commit into
Closed
TM iOS: Remove retainArguments && do retain by us explicitly#24849zhongwuzw wants to merge 1 commit into
zhongwuzw wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
matthargett
reviewed
May 14, 2019
Contributor
matthargett
left a comment
matthargett
left a comment
There was a problem hiding this comment.
Can you add a unit test that demonstrates this new behavior?
Contributor
Author
|
@matthargett Yeah, I'll see how I can do it. :) |
Contributor
|
This is awesome! 😁 |
Contributor
Author
|
TM is still in progress, so I think we can't write unit test which integrated into CI? @RSNara Update: @matthargett After talking to Kevin, we can do it for later, maybe after TM is entirely ready. 🍻 |
facebook-github-bot
approved these changes
May 16, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fkgozali is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @zhongwuzw in a352ecf. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
…k#24849) Summary: This is a TODO, we met crash if we don't call `retainArguments` when return type is like `NSDictionary`, the reason is `getReturnValue` don't retain the return value, so we need to using `__bridge` to transfer ownership to OC type. Also add `resolveBlock` and `rejectBlock` to `retainedObjectsForInvocation`. cc. cpojer ## Changelog [iOS] [Fixed] - Remove retainArguments && do retain by us explicitly Pull Request resolved: facebook#24849 Differential Revision: D15369209 Pulled By: fkgozali fbshipit-source-id: 8431d03705d8476f38c8b5d29630489a545d373a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a TODO, we met crash if we don't call
retainArgumentswhen return type is likeNSDictionary, the reason isgetReturnValuedon't retain the return value, so we need to using__bridgeto transfer ownership to OC type.Also add
resolveBlockandrejectBlocktoretainedObjectsForInvocation.cc. @cpojer
Changelog
[iOS] [Fixed] - Remove retainArguments && do retain by us explicitly
Test Plan
TM example can run successfully.