Skip to content

[TM] Add spec for HeapCapture #24899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wojteg1337 wants to merge 3 commits into from
Closed

[TM] Add spec for HeapCapture #24899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80e236b
[TM] Add spec for HeapCapture
wojteg1337 May 16, 2019
704bb8b
fix: add conditional export for platform specific module
wojteg1337 May 17, 2019
2cdd85f
fix: remove unnecesary comments
wojteg1337 May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Core/setUpBatchedBridge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ BatchedBridge.registerLazyCallableModule('JSTimers', () =>
require('./Timers/JSTimers'),
);
BatchedBridge.registerLazyCallableModule('HeapCapture', () =>
require('../Utilities/HeapCapture'),
require('../HeapCapture/HeapCapture'),
Copy link
Copy Markdown
Contributor

@ericlewis ericlewis May 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requiring like this means you should also grab default i think.

Copy link
Copy Markdown
Contributor Author

@wojteg1337 wojteg1337 May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure if there should be default since export looks like this:

module.exports = HeapCapture;

Copy link
Copy Markdown
Contributor

@ericlewis ericlewis May 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah gotcha, thought this was coming direct from NativeHeapCapture

);
BatchedBridge.registerLazyCallableModule('SamplingProfiler', () =>
require('../Performance/SamplingProfiler'),
Expand Down
9 changes: 5 additions & 4 deletions Libraries/Utilities/HeapCapture.js → Libraries/HeapCapture/HeapCapture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

'use strict';

import NativeHeapCapture from './NativeHeapCapture';

const HeapCapture = {
captureHeap: function(path: string) {
let error = null;
Expand All @@ -20,10 +22,9 @@ const HeapCapture = {
console.log('HeapCapture.captureHeap error: ' + e.toString());
error = e.toString();
}
require('../BatchedBridge/NativeModules').JSCHeapCapture.captureComplete(
path,
error,
);
if (NativeHeapCapture) {
NativeHeapCapture.captureComplete(path, error);
}
},
};

Expand Down
24 changes: 24 additions & 0 deletions Libraries/HeapCapture/NativeHeapCapture.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
*/

'use strict';

import type {TurboModule} from 'RCTExport';
import * as TurboModuleRegistry from 'TurboModuleRegistry';
import {Platform} from 'react-native';

export interface Spec extends TurboModule {
+captureHeap: (path: string) => void;
+captureComplete: (path: string, error: ?string) => void;
}

export default (Platform.OS === 'android'
? TurboModuleRegistry.getEnforcing<Spec>('HeapCapture')
: null);