[TM] Add spec for ExceptionsManager#24900
Conversation
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
| /** | ||
| * Available only on Android | ||
| */ | ||
| +dismissRedbox: () => void; |
There was a problem hiding this comment.
Should we need to split it to Android and iOS? if not, seems we need to label it for Codegen.
There was a problem hiding this comment.
For additional properties we have decided to generate it on both platforms and no-op on one, so for this you can update the comment to // Android only and keep it in one file
Splitting out would be required for props/events that conflict
There was a problem hiding this comment.
Also, we should make platform-specific properties optional. We don't want this to be a required method on the protocol we generate for iOS.
RSNara
left a comment
RSNara
left a comment
There was a problem hiding this comment.
Looks good! However, we need to make a few changes before we can land this.
| /** | ||
| * Available only on Android | ||
| */ | ||
| +dismissRedbox: () => void; |
There was a problem hiding this comment.
Also, we should make platform-specific properties optional. We don't want this to be a required method on the protocol we generate for iOS.
|
|
||
| import type {TurboModule} from 'RCTExport'; | ||
| import * as TurboModuleRegistry from 'TurboModuleRegistry'; | ||
| import type {StackFrame} from './Devtools/parseErrorStack'; |
There was a problem hiding this comment.
Unfortunately, our current TM codegen doesn't support type imports. I wonder if we should move StackFrame to this Spec file and instead import the type in parseErrorStack. If not, then we should just declare these twice.
There was a problem hiding this comment.
Moved the type def to NativeExceptionsManager as there wasn't too many call-sites to change
thymikee
force-pushed
the
feat/type-exceptions-manager
branch
from
bf1e285 to
c39de6b
Compare
| exceptionId: number, | ||
| ) => void; | ||
| // Android only | ||
| +dismissRedbox?: () => void; |
There was a problem hiding this comment.
@RSNara 🤔 Seems sentIntent of IntentAndroid not marks optional
https://github.com/facebook/react-native/pull/24877/files#diff-7033e846872152e52446abb20da3efb8R25, should we also changed that?
There was a problem hiding this comment.
Yeah, nice catch. We should change that.
There was a problem hiding this comment.
Actually, no. I was wrong earlier about our codegen output. Turns out, regardless of if a method is optional or not, it'll generate a required method in native. So, making this optional doesn't do anything.
RSNara
left a comment
RSNara
left a comment
There was a problem hiding this comment.
Looks good! Thanks for addressing the comments. 👍
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @thymikee in 8ea749a. When will my fix make it into a release? | Upcoming Releases |
Summary: Part of facebook#24875, adds a spec for ExceptionsManager ## Changelog [General] [Added] - TM Add spec for ExceptionsManager Pull Request resolved: facebook#24900 Reviewed By: fkgozali Differential Revision: D15434006 Pulled By: RSNara fbshipit-source-id: 1a505744a84c0c4ac3a9fac6c91a391fbd8a9f46
8 participants
Summary
Part of #24875, adds a spec for ExceptionsManager
Changelog
[General] [Added] - TM Add spec for ExceptionsManager
Test Plan
Flow passes.