[TM] spec for JSCSamplingProfiler#24903
Closed
ericlewis wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
fkgozali
reviewed
May 20, 2019
| } | ||
|
|
||
| export default (Platform.OS === 'android' | ||
| ? TurboModuleRegistry.getEnforcing<Spec>('JSCSamplingProfiler') |
Contributor
There was a problem hiding this comment.
Like in other PRs, this should call .get() instead, no need to check for platform
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @ericlewis in 6c573f7. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: part of facebook#24875. ## Changelog [General] [Added] - Add TM spec for JSCSamplingProfiler Pull Request resolved: facebook#24903 Reviewed By: RSNara Differential Revision: D15421649 Pulled By: fkgozali fbshipit-source-id: 3d5a04a135aa7640495a0eb682b9c2300636db8e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
part of #24875.
Changelog
[General] [Added] - Add TM spec for JSCSamplingProfiler
Test Plan
Flow passes.