[TM] Add spec for AnimatedModule#24911
Conversation
facebook-github-bot
added
CLA Signed
thymikee
force-pushed
the
feat/type-animated-module
branch
from
98799ad to
20650b3
Compare
react-native-bot
added
API: Animated
Type: Enhancement
|
I was working on that, but I'm glad to see it's finished \o/ |
|
@uqmessias so it seems like you're perfectly eligible to help reviewing this 😊 |
| |}; | ||
|
|
||
| export type AnimatedNodeConfig = {| | ||
| type?: |
There was a problem hiding this comment.
should this be required? (no ?)
| |}; | ||
|
|
||
| export type AnimatingNodeConfig = {| | ||
| type?: 'frames' | 'spring' | 'decay', |
There was a problem hiding this comment.
this too should be required?
| animationId: ?number, | ||
| nodeTag: ?number, | ||
| config: AnimatingNodeConfig, | ||
| endCallback: EndCallback, |
There was a problem hiding this comment.
type imported from other files doesn't work well with our codegen atm, so just inline the type here or copy the type over in this file
|
@fkgozali addressed the feedback, thanks! |
|
|
||
| export type AnimatedNodeConfig = {| | ||
| type: | ||
| | 'style' |
There was a problem hiding this comment.
Hmm actually we don't yet support enums, so I'll just update this to string when I import to FB, for now... Sorry for the confusion. cc @RSNara
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @thymikee in 116ac65. When will my fix make it into a release? | Upcoming Releases |
Summary: Part of facebook#24875. Added `strict-local` to the NativeModuleHelper btw. ## Changelog [General] [Added] - TM add spec for AnimatedModule Pull Request resolved: facebook#24911 Reviewed By: rickhanlonii Differential Revision: D15434114 Pulled By: fkgozali fbshipit-source-id: ea9215306ebf969795ce755270b8fdc14c52da9c
8 participants
Summary
Part of #24875. Added
strict-localto the NativeModuleHelper btw.Changelog
[General] [Added] - TM add spec for AnimatedModule
Test Plan
Flow green.