[TM] Add spec for DialogManagerAndroid #24912
Conversation
c2325b8 to
ba573b5
Compare
19ee97f to
c8e824d
Compare
RSNara
left a comment
There was a problem hiding this comment.
Looks mostly good! 😁
However, I do have a few questions/concerns. Could you look through my comments?
There was a problem hiding this comment.
Unfortunately, the Codegen system doesn't support unions. 😔
So, I think it's best if we change this to string.
There was a problem hiding this comment.
What about keeping this as it is and adding and updating DialogAction to type DialogAction = string?
There was a problem hiding this comment.
Looking through the code, it seems like onAction can also be invoked without the buttonKey:
@Override
public void onDismiss(DialogInterface dialog) {
if (!mCallbackConsumed) {
if (getReactApplicationContext().hasActiveCatalystInstance()) {
mCallback.invoke(ACTION_DISMISSED);
mCallbackConsumed = true;
}
}
}So we should make this argument nullable.
There was a problem hiding this comment.
@RSNara, I saw one of your comments in another PR about the codegen not supporting enum or union types. So, based on that, these two types (DialogAction and DialogButtonKey) are not supported by the codegen, right?
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
95a8aae to
ba8d9f2
Compare
|
@RSNara, |
RSNara
left a comment
There was a problem hiding this comment.
Looks good! Thank you for iterating on this. 😁
facebook-github-bot
left a comment
There was a problem hiding this comment.
@RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @uqmessias in 32340d3. When will my fix make it into a release? | Upcoming Releases |
Summary: Part of facebook#24875. ## Changelog [General] [Added] - TM add spec for DialogManagerAndroid Pull Request resolved: facebook#24912 Reviewed By: fkgozali Differential Revision: D15433854 Pulled By: RSNara fbshipit-source-id: e7234debe16de5afbc770f8feee2471f41b54427
Summary
Part of #24875.
Changelog
[General] [Added] - TM add spec for DialogManagerAndroid
Test Plan
Flow green.