Skip to content

[TM] Add spec for NativeDeviceEventManager#24914

Closed
uqmessias wants to merge 1 commit into
facebook:masterfrom
uqmessias:feat/spec-device-event-manager
Closed

[TM] Add spec for NativeDeviceEventManager#24914
uqmessias wants to merge 1 commit into
facebook:masterfrom
uqmessias:feat/spec-device-event-manager

Conversation

@uqmessias
Copy link
Copy Markdown
Contributor

Summary

Part of #24875.

Changelog

[General] [Added] - TM add spec for NativeDeviceEventManager

Test Plan

Flow green.

@uqmessias uqmessias force-pushed the feat/spec-device-event-manager branch from 40aec62 to 0e46ce7 Compare May 16, 2019 19:55
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label May 16, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2019
@ericlewis ericlewis added the Flow label May 16, 2019
@uqmessias uqmessias force-pushed the feat/spec-device-event-manager branch 4 times, most recently from 48635f7 to 3eabcf1 Compare May 16, 2019 23:02
Copy link
Copy Markdown
Contributor

@ericlewis ericlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uqmessias uqmessias force-pushed the feat/spec-device-event-manager branch from 3eabcf1 to d89afec Compare May 17, 2019 22:05
@uqmessias uqmessias force-pushed the feat/spec-device-event-manager branch from d89afec to 63cdaff Compare May 20, 2019 14:33
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @uqmessias in 580088c.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 21, 2019
@uqmessias uqmessias deleted the feat/spec-device-event-manager branch July 24, 2019 19:13
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
Part of facebook#24875.

## Changelog

[General] [Added] - TM add spec for NativeDeviceEventManager
Pull Request resolved: facebook#24914

Reviewed By: RSNara

Differential Revision: D15421462

Pulled By: fkgozali

fbshipit-source-id: 78b90c615cd031ecd010a552751e506406ab739a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Flow Merged This PR has been merged. Native Module Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants