[TM] add spec for RedBox#24922
Conversation
facebook-github-bot
added
CLA Signed
react-native-bot
added
the
Type: Enhancement
|
|
||
| export default (Platform.OS === 'ios' | ||
| ? TurboModuleRegistry.getEnforcing<Spec>('RedBox') | ||
| : null); |
There was a problem hiding this comment.
Shouldn't we use undefined here instead?
There was a problem hiding this comment.
hmm good question, I didn't see anything about using it specifically. But it would be nice to have a consensus.
There was a problem hiding this comment.
I saw some of the specific platforms PRs using undefined and others using null.
I don't have a strong opinion on that, but my preference is to go with undefined what denotes that this Native Module "was not defined" for this platform.
Anyway, I can update my PRs if we decide to go with null.
There was a problem hiding this comment.
We should actually be using get not get enforcing
There was a problem hiding this comment.
Yeah, I'll update it before I import/land to FB
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ericlewis in c44d4f9. When will my fix make it into a release? | Upcoming Releases |
Summary: part of facebook#24875. ## Changelog [General] [Added] - add TM spec for RedBox Pull Request resolved: facebook#24922 Reviewed By: RSNara Differential Revision: D15423532 Pulled By: fkgozali fbshipit-source-id: 3c30e5b32a29628caf0bb9286c0628597ac64fb7
7 participants
Summary
part of #24875.
Changelog
[General] [Added] - add TM spec for RedBox
Test Plan
Flow passes