Skip to content

[iOS] Using presentingViewController to dismiss Modal #24959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhongwuzw wants to merge 1 commit into from
Closed

[iOS] Using presentingViewController to dismiss Modal #24959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion React/Views/RCTModalHostViewManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ - (void)dismissModalHostView:(RCTModalHostView *)modalHostView withViewControlle
if (_dismissalBlock) {
_dismissalBlock([modalHostView reactViewController], viewController, animated, completionBlock);
} else {
[viewController dismissViewControllerAnimated:animated completion:completionBlock];
[viewController.presentingViewController dismissViewControllerAnimated:animated completion:completionBlock];
Copy link
Copy Markdown
Contributor

@shergin shergin May 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is clear and confirms my recollections:

dismissViewControllerAnimated:completion:

Dismisses the view controller that was presented modally by the view controller.
SDKs

So, the fix looks perfectly legit to me, the only Q that prevents me from landing it:
I don't understand how/why it worked previously. Did it? (Until we find answer to this question we cannot be sure that our conclusions are correct.)

Copy link
Copy Markdown
Contributor

@janicduplessis janicduplessis May 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin Could be why it works, but maybe it dismisses the wrong vc sometimes.

 If you call this method on the presented view controller itself, UIKit asks the presenting view controller to handle the dismissal.

Thanks for clarifiying what reactViewController is. LGTM

Copy link
Copy Markdown
Contributor Author

@zhongwuzw zhongwuzw May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we just have one Modal, it works whatever we passed presented VC or presenting VC, but if we have multiple Modals, bug may happen, for example, VC present Modal A, ModalA present Modal B, if we call [ModalA dismissVC], what this should perform? because ModalA is the presenting VC to present ModalB,but it also the presented VC which presenting VC is the closest VC when present ModalA, I think this is why bug happened. :)

}
}

Expand Down