Use default OK on buttonPositive to prevent showing an alert without any buttons

[Mookiies]

Summary

Solve #25016

Use OK as default text for the affirmative button if no text is specified. When setting an alert on android with button configuration, and no text field specified no button is shown on the alert. This makes it impossible to dismiss. An example of how this can happen is creating a simple button where a onPress callback is used but no text is specified:

Alert.alert(
   'title',
   'message',
   [ { onPress: () => console.log('onPress') } ],
)

Does not change the current behavior of no text button configurations on iOS. On iOS at least one button is always shown, and buttons with no text can be displayed.

Behavior on setting multiple buttons is a little wonky, but this PR does not aim to solve it. I did test these cases and included some examples below.

Changelog

[Android] [Fixed] - Use OK as default text on Android Alert if button configuration specified without text

Test Plan

Tested alerts with varying configurations set

Configuration without text, one button:

Alert.alert(
'title',
'message',
[ {  onPress: () => console.log('first') } ])

Configuration without text, two button:

Alert.alert(
'title',
'message',
[
    {  onPress: () => console.log('first') },
    {  onPress: () => console.log('first') },
],
)

Configuration without text, three buttons

Alert.alert(
'title',
'message',
[
    {  onPress: () => console.log('first') },
    {  onPress: () => console.log('second') },
    {  onPress: () => console.log('third') },
],
)

Custom text for two of three buttons:

Alert.alert(
'title',
'message',
[
    {  text: 'first', onPress: () => console.log('first') },
    {  text: 'second', onPress: () => console.log('second') },
    {  onPress: () => console.log('third') },
],
)

Custom text for first button only:

Alert.alert(
'title',
'message',
[
    {  text: 'first', onPress: () => console.log('first') },
    {  onPress: () => console.log('second') },
    {  onPress: () => console.log('third') },
],
)

No button configuration:

Alert.alert(
'title',
'message',
)

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[cpojer]

Sounds good! Thank you :)

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @MalcolmScruggs in fa97b23.

^{When will my fix make it into a release? | Upcoming Releases}

[cinder92]

this shows an OK button automatically, but if i add a text with Ok, it shows twice

{
                  text: 'Ok',
                  onPress: () => {
                  },
                },

this shows 2 ok buttons ok the alert for android