Skip to content

add warning for StatusBarIOS#25350

Closed
ecreeth wants to merge 2 commits into
facebook:masterfrom
ecreeth:master
Closed

add warning for StatusBarIOS#25350
ecreeth wants to merge 2 commits into
facebook:masterfrom
ecreeth:master

Conversation

@ecreeth
Copy link
Copy Markdown
Contributor

@ecreeth ecreeth commented Jun 21, 2019

Summary

StatusBarIOS has been merged with StatusBar. See Implement a StatusBar frame API

Changelog

[General] [Deprecate] - Warning for StatusBarIOS

Test Plan

Warning prints when user imports StatusBarIOS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 21, 2019
Copy link
Copy Markdown

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues. Run yarn lint --fix to automatically fix problems.

Comment thread Libraries/react-native/react-native-implementation.js Outdated
Comment thread Libraries/react-native/react-native-implementation.js Outdated
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jun 21, 2019

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against b16e7e2

Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @ecreeth in a833778.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 24, 2019
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
`StatusBarIOS` has been merged with `StatusBar`. See [Implement a StatusBar frame API](facebook#16478)

## Changelog

[General] [Deprecate] -  Warning for `StatusBarIOS`
Pull Request resolved: facebook#25350

Test Plan: Warning prints when user imports `StatusBarIOS`

Differential Revision: D15963347

Pulled By: cpojer

fbshipit-source-id: 456a7f3ccb245bd89ad322d5a2649e3bf844ba24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API: StatusBarIOS CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: StatusBar Merged This PR has been merged. Platform: iOS iOS applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants