Skip to content

bump fresco to 2.0.0, supports AndroidX#25358

Closed
dulmandakh wants to merge 1 commit into
facebook:masterfrom
dulmandakh:fresco-2.0.0
Closed

bump fresco to 2.0.0, supports AndroidX#25358
dulmandakh wants to merge 1 commit into
facebook:masterfrom
dulmandakh:fresco-2.0.0

Conversation

@dulmandakh
Copy link
Copy Markdown
Contributor

@dulmandakh dulmandakh commented Jun 22, 2019

Summary

Bump Fresco to 2.0.0, which supports AndroidX. We should cherry-pick to 0.60 release, to support brown field apps but also native components.

Changelog

[Android] [Changed] - Bump Fresco to 2.0.0, supports AndroidX

Test Plan

CI is green, and RNTester builds and runs as expected.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Jun 22, 2019
@react-native-bot react-native-bot added the Platform: Android Android applications. label Jun 22, 2019
@dulmandakh dulmandakh requested a review from cpojer June 22, 2019 05:30
@dulmandakh
Copy link
Copy Markdown
Contributor Author

dulmandakh commented Jun 22, 2019

@cpojer @kelset I would like to this change to be cherry-picket into 0.60 release, as it uses Fresco with AndroidX support.

@dulmandakh dulmandakh requested a review from mdvacca June 22, 2019 06:21
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @dulmandakh in 0af25a8.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 23, 2019
kelset pushed a commit that referenced this pull request Jun 28, 2019
Summary:
Bump Fresco to 2.0.0, which supports AndroidX. We should cherry-pick to 0.60 release, to support brown field apps but also native components.

## Changelog

[Android] [Changed] - Bump Fresco to 2.0.0, supports AndroidX
Pull Request resolved: #25358

Test Plan: CI is green, and RNTester builds and runs as expected.

Differential Revision: D15959443

Pulled By: mdvacca

fbshipit-source-id: 58ba2c3e4d1342014d6ea632cd865b4f413548d9
@dulmandakh dulmandakh deleted the fresco-2.0.0 branch October 15, 2019 05:14
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
Bump Fresco to 2.0.0, which supports AndroidX. We should cherry-pick to 0.60 release, to support brown field apps but also native components.

## Changelog

[Android] [Changed] - Bump Fresco to 2.0.0, supports AndroidX
Pull Request resolved: facebook#25358

Test Plan: CI is green, and RNTester builds and runs as expected.

Differential Revision: D15959443

Pulled By: mdvacca

fbshipit-source-id: 58ba2c3e4d1342014d6ea632cd865b4f413548d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants