Skip to content

Add e2e tests skeleton for generated cpp code#25673

Closed
osdnk wants to merge 1 commit into
facebook:masterfrom
osdnk:export-D16221277
Closed

Add e2e tests skeleton for generated cpp code#25673
osdnk wants to merge 1 commit into
facebook:masterfrom
osdnk:export-D16221277

Conversation

@osdnk
Copy link
Copy Markdown
Contributor

@osdnk osdnk commented Jul 16, 2019

NOTE: This PR was done in order to validate buck build on CI. Do not merge!
Summary:
This diff add e2e code generator validation. I added proper buck roles and added tests.

Also, fixed few minor problems:
getBool and getNumber shouldn't have rt param.

Generators now start considering whole module name instead of sliced part of their name.

Fixed import structure.

Fixed filename in generate cpp code (previously was NativeModules.h, now it's cpp file)

renamed jsireact to ReactCommon following D16231697

Differential Revision: D16221277

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team labels Jul 16, 2019
@pull-bot
Copy link
Copy Markdown

pull-bot commented Jul 16, 2019

Messages
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 7742097

Summary:
Pull Request resolved: #25673

This diff add e2e code generator validation. I added proper buck roles and added tests.

Also, fixed few minor problems:
`getBool` and `getNumber` shouldn't have `rt` param.

Generators now start considering whole module name instead of sliced part of their name.

Fixed import structure.

Fixed filename in generate cpp code (previously was `NativeModules.h`, now it's cpp file)

renamed `jsireact` to `ReactCommon` following D16231697

Differential Revision: D16221277

fbshipit-source-id: 6d57dcf329231e27befb6b97188090bff5d8dd4e
@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @osdnk in d672247.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants