Add e2e tests skeleton for generated cpp code#25673
Closed
osdnk wants to merge 1 commit into
Closed
Conversation
|
Summary: Pull Request resolved: #25673 This diff add e2e code generator validation. I added proper buck roles and added tests. Also, fixed few minor problems: `getBool` and `getNumber` shouldn't have `rt` param. Generators now start considering whole module name instead of sliced part of their name. Fixed import structure. Fixed filename in generate cpp code (previously was `NativeModules.h`, now it's cpp file) renamed `jsireact` to `ReactCommon` following D16231697 Differential Revision: D16221277 fbshipit-source-id: 6d57dcf329231e27befb6b97188090bff5d8dd4e
Collaborator
|
This pull request was successfully merged by @osdnk in d672247. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR was done in order to validate buck build on CI. Do not merge!
Summary:
This diff add e2e code generator validation. I added proper buck roles and added tests.
Also, fixed few minor problems:
getBoolandgetNumbershouldn't havertparam.Generators now start considering whole module name instead of sliced part of their name.
Fixed import structure.
Fixed filename in generate cpp code (previously was
NativeModules.h, now it's cpp file)renamed
jsireacttoReactCommonfollowing D16231697Differential Revision: D16221277