[Android][Fix] Revert Picker item original color

[cabelitos]

Summary

Since the Android's Picker implementation uses an ArrayAdapter,
it means that the views that were created may be reused for other items
in order to save memory. With this in mind, if one sets the Picker.Item
prop color for only certain items there might be an state that
some items that does not have the color set will end up appearing
with the wrong color. This happens because, this new item is
reusing a view of an item that had the color prop set.
In order to avoid this problem, once a new view is created
the ReactPickerAdapter will save the original color and
re-apply if the item does not have the color prop.

Changelog

[Android] [Fixed] - Picker.Item displays wrong colors

Test Plan

On android execute the code below. Only the FIRST item should be red.

import React from 'react';
import { StyleSheet, View, Picker } from 'react-native';

const values = new Array(100);

for (let i = 0; i < values.length; i += 1) {
  values[i] = (i * i).toString();
}

const App = () => {
  const [selected, setSelected] = React.useState(0);
  const onValueChange = React.useCallback((_, idx) => {
    setSelected(idx);
  }, []);
  return (
    <View style={styles.container}>
      <Picker onValueChange={onValueChange} selectedValue={values[selected]}>
        {values.map((v, i) => (
          <Picker.Item
            key={v}
            value={v}
            label={v}
            {...(!i ? { color: 'red' } : {})}
          />
        ))}
      </Picker>
    </View>
  );
};

export default App;

const styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    paddingHorizontal: 20,
  },
});

Without the patch

You should see various items with the red color (when only the first one should be red)

With the patch

Only the first item is red.

Closes #25456

[mdvacca]

LGTM

[mdvacca]

Since you are touching this file, can you return textView instead?

[mdvacca]

Hey @cabelitos, thanks for fixing this!
It looks good to me, if you have 5 min to make that change it would be great. Otherwise I will just land this as it is!

[cabelitos]

Thank you for your review @mdvacca. I'm doing the change right now!

[cabelitos]

@mdvacca did the change, please let me know what you think.
And once again thank you and your colleagues for the support.

[mdvacca]

Looks great, thanks!

I'm landing the PR

[facebook-github-bot]

@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @cabelitos in 5b953e5.

^{When will my fix make it into a release? | Upcoming Releases}