bump android gradle plugin to 3.5.0#26129
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
@osdnk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @dulmandakh in 4763000. When will my fix make it into a release? | Upcoming Releases |
|
@dulmandakh The build is failing immediately: Anything missing on my side? |
|
@dulmandakh - Any update on this? I just double checked and ran the same command on two different machines (Linux and macOS) - So I'm pretty sure it's not something local. After reverting 4763000 everything works right away. Can you check please? Thanks! |
Summary: Android Gradle Plugin 3.5.0 released with a lot of improvements and bug fixes. It's important to have this change merged before 0.61 release. See https://developer.android.com/studio/releases/gradle-plugin ## Changelog [Android] [Changed] - bump android gradle plugin to 3.5.0 Pull Request resolved: #26129 Test Plan: RNTester builds and runs as expected Reviewed By: mdvacca Differential Revision: D17091520 Pulled By: osdnk fbshipit-source-id: 232b9209526e62a7344d74422fd8471a03dec7f4
|
I confirm this is breaking on the release branch too. It would be great to resolve this issue as it may be potentially breaking master builds as well. CC: @cpojer for a bit of help with coordinating it. |
Summary
Android Gradle Plugin 3.5.0 released with a lot of improvements and bug fixes. It's important to have this change merged before 0.61 release. See https://developer.android.com/studio/releases/gradle-plugin
Changelog
[Android] [Changed] - bump android gradle plugin to 3.5.0
Test Plan
RNTester builds and runs as expected