Skip to content

bump android gradle plugin to 3.5.0#26129

Closed
dulmandakh wants to merge 1 commit into
facebook:masterfrom
dulmandakh:android-gradle-plugin-3.5.0
Closed

bump android gradle plugin to 3.5.0#26129
dulmandakh wants to merge 1 commit into
facebook:masterfrom
dulmandakh:android-gradle-plugin-3.5.0

Conversation

@dulmandakh
Copy link
Copy Markdown
Contributor

@dulmandakh dulmandakh commented Aug 21, 2019

Summary

Android Gradle Plugin 3.5.0 released with a lot of improvements and bug fixes. It's important to have this change merged before 0.61 release. See https://developer.android.com/studio/releases/gradle-plugin

Changelog

[Android] [Changed] - bump android gradle plugin to 3.5.0

Test Plan

RNTester builds and runs as expected

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Aug 21, 2019
@dulmandakh dulmandakh requested review from cpojer and mdvacca August 21, 2019 03:10
@dulmandakh dulmandakh added the Platform: Android Android applications. label Aug 21, 2019
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osdnk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @dulmandakh in 4763000.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 29, 2019
@friederbluemle
Copy link
Copy Markdown
Contributor

@dulmandakh The build is failing immediately:

$ ./gradlew tasks
Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* Where:
Build file '[...]/ReactAndroid/build.gradle' line: 220

* What went wrong:
A problem occurred evaluating project ':ReactAndroid'.
> extensionSupplier.get()!!.compileSdkVersion must not be null

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring project ':ReactAndroid'.
> compileSdkVersion is not specified.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 5s

Anything missing on my side?

@friederbluemle
Copy link
Copy Markdown
Contributor

@dulmandakh - Any update on this? I just double checked and ran the same command on two different machines (Linux and macOS) - So I'm pretty sure it's not something local. After reverting 4763000 everything works right away. Can you check please? Thanks!
@gengjiawen @osdnk - Were you able to verify this locally when reviewing the PR?

@dulmandakh dulmandakh deleted the android-gradle-plugin-3.5.0 branch August 31, 2019 11:34
grabbou pushed a commit that referenced this pull request Sep 24, 2019
Summary:
Android Gradle Plugin 3.5.0 released with a lot of improvements and bug fixes. It's important to have this change merged before 0.61 release. See https://developer.android.com/studio/releases/gradle-plugin

## Changelog

[Android] [Changed] - bump android gradle plugin to 3.5.0
Pull Request resolved: #26129

Test Plan: RNTester builds and runs as expected

Reviewed By: mdvacca

Differential Revision: D17091520

Pulled By: osdnk

fbshipit-source-id: 232b9209526e62a7344d74422fd8471a03dec7f4
@grabbou
Copy link
Copy Markdown
Contributor

grabbou commented Sep 24, 2019

I confirm this is breaking on the release branch too. It would be great to resolve this issue as it may be potentially breaking master builds as well.

CC: @cpojer for a bit of help with coordinating it.

grabbou added a commit that referenced this pull request Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants