Better implementation for getItemCount on FlatList#26164
Closed
ifsnow wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
sahrens
approved these changes
Aug 23, 2019
Contributor
sahrens
left a comment
sahrens
left a comment
There was a problem hiding this comment.
Thanks - definitely nice to avoid the division in the common case with numColumns == 1 in such a hot path!
facebook-github-bot
approved these changes
Aug 23, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@sahrens is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @ifsnow in bb05176. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flatlist's
getItemCountfunction is frequently called internally by VirtualizedList.As with other functions, we can remove unnecessary operations with the
numColumnsvalue.This makes it much more efficient.
Changelog
[Internal] [Changed] - Better implementation for getItemCount on FlatList
Test Plan
Not required