Skip lint check for dynamic react-native version#26222
Closed
friederbluemle wants to merge 1 commit into
Closed
Conversation
This prevents a Gradle lint warning about the version of the react-native dependency from node_modules.
facebook-github-bot
added
the
CLA Signed
Contributor
|
Thanks! Makes sense! |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@osdnk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
osdnk
approved these changes
Aug 28, 2019
dulmandakh
approved these changes
Aug 29, 2019
mdvacca
approved these changes
Sep 4, 2019
Contributor
mdvacca
left a comment
mdvacca
left a comment
There was a problem hiding this comment.
Accepting and Landing it
cpojer
approved these changes
Sep 9, 2019
Contributor
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
Somehow didn't land, will retry.
Contributor
|
yayyy! it passed |
Collaborator
|
This pull request was successfully merged by @friederbluemle in 87f94d5. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dependenciessection in thebuild.gradleAndroid template contains this line:It causes the following Gradle Lint warning:
In this case, as the
// From node_modulescomment suggests, the version is not determined by Gradle but by the version specified inpackage.json- Using "+" is completely fine and intentional.Therefore it can safely be ignored, which is what the added
//noinspectiondoes.Changelog
[Android] [Fixed] - Skip lint check for dynamic react-native version
Test Plan
Projects generated with the new template no longer cause the warning.