[General] [Fixed] Fix incorrect module.name_mapper in template .flowconfig#26330
Closed
MoOx wants to merge 1 commit into
Closed
[General] [Fixed] Fix incorrect module.name_mapper in template .flowconfig#26330MoOx wants to merge 1 commit into
module.name_mapper in template .flowconfig#26330MoOx wants to merge 1 commit into
Conversation
…wconfig Has explained in #26233, current template is incorrect & can create error, like having require() of png that are considered as `string` instead of `number. This can probably hide tons of similar mistakes. The change in this PR should resolve the previous behavior (& for example, some places in previous version of the flowconfig have the full path like here https://github.com/facebook/react-native/blob/35300147ca66677f42e8544264be72ac0e9d1b45/template/_flowconfig#L61) Closes #26233 Alternatively, message could be ``` [General] [Fixed] Fix incorrect `module.name_mapper` in template .flowconfig ``` As it hasn't this "bug" hasn't been released in a public stable release. You decide
facebook-github-bot
added
the
CLA Signed
MoOx
changed the title
module.name_mapper in template .flo wconfigmodule.name_mapper in template .flowconfig
thymikee
approved these changes
Sep 8, 2019
Contributor
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Yep, looks good, thank you!
facebook-github-bot
approved these changes
Sep 9, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @MoOx in e6b2cf0. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
Sep 10, 2019
Summary: Has explained in #26233, current template is incorrect & can create error, like having require() of png that are considered as `string` instead of `number. This can probably hide tons of similar mistakes. The change in this PR should resolve the previous behavior (& for example, some places in previous version of the flowconfig have the full path like here https://github.com/facebook/react-native/blob/35300147ca66677f42e8544264be72ac0e9d1b45/template/_flowconfig#L61) Closes #26233 ## Changelog ``` [General] [Fixed] Fix incorrect `module.name_mapper` in template .flowconfig ``` Alternatively, message could be ``` [General] [Internal] Fix incorrect `module.name_mapper` in template .flowconfig ``` As it hasn't this "bug" hasn't been released in a public stable release. You decide Pull Request resolved: #26330 Test Plan: I just tested this in my project, thymikee might be able to confirm & approve this PR. Differential Revision: D17258891 Pulled By: cpojer fbshipit-source-id: 3904ffbc6f076ee0e435311249d694b8604fc7b8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Has explained in #26233, current template is incorrect & can create error, like having require() of png that are considered as
stringinstead of `number. This can probably hide tons of similar mistakes.The change in this PR should resolve the previous behavior (& for example, some places in previous version of the flowconfig have the full path like here
react-native/template/_flowconfig
Line 61 in 3530014
Closes #26233
Changelog
Alternatively, message could be
As it hasn't this "bug" hasn't been released in a public stable release. You decide
Test Plan
I just tested this in my project, @thymikee might be able to confirm & approve this PR.