Skip to content

fix typo in comment about package#26638

Closed
ma96o wants to merge 1 commit into
facebook:masterfrom
ma96o:fix-typo-package
Closed

fix typo in comment about package#26638
ma96o wants to merge 1 commit into
facebook:masterfrom
ma96o:fix-typo-package

Conversation

@ma96o
Copy link
Copy Markdown
Contributor

@ma96o ma96o commented Sep 29, 2019

Summary

This PR only fixes a typo in ModuleHolder.java.

Changelog

[Internal] [Fixed] - Fix typo in comment about package

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link
Copy Markdown

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 1f50059

@react-native-bot react-native-bot added Bug No CLA Authors need to sign the CLA before a PR can be reviewed. labels Sep 29, 2019
Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpojer
Copy link
Copy Markdown
Contributor

cpojer commented Sep 30, 2019

@ma96o could you sign the CLA under code.facebook.com/cla so we can merge this PR?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2019
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-native-bot react-native-bot removed the No CLA Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2019
@ma96o
Copy link
Copy Markdown
Contributor Author

ma96o commented Sep 30, 2019

@cpojer Thanks for review.
I have signed the CLA!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @ma96o in 231d2f9.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants