Skip to content

Updated Jitpack URL in android template to fix gradle errors#26660

Closed
AndrewBastin wants to merge 1 commit into
facebook:masterfrom
AndrewBastin:master
Closed

Updated Jitpack URL in android template to fix gradle errors#26660
AndrewBastin wants to merge 1 commit into
facebook:masterfrom
AndrewBastin:master

Conversation

@AndrewBastin
Copy link
Copy Markdown
Contributor

Summary

Running react-native run-android fails for me with the error saying connection timed out for fetching a library from jitpack. This seems to be a well known issue mentioned around. The issue is resolved by updating the url from https://jitpack.io to https://www.jitpack.io .

Changelog

[Android] [Fixed] - Updated template/android/build.gradle with a modified jitpack URL

Test Plan

  1. Create a new react-native app with react-native init <app-name>
  2. Run react-native run-android
  3. App runs without modifications!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added Platform: Android Android applications. Bug labels Oct 1, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 1, 2019
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @AndrewBastin in 018b748.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 28, 2019
@sonicdoe
Copy link
Copy Markdown
Contributor

I’ve stumbled over this pull request when upgrading React Native to v0.62. If anyone’s curious, there’s an open issue over at jitpack/jitpack.io#4002 and Expo made the same change with expo/expo#5892.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants