Skip to content

Fix minor typos in react-native-codegen errors#26714

Closed
solon wants to merge 1 commit into
facebook:masterfrom
solon:patch-2
Closed

Fix minor typos in react-native-codegen errors#26714
solon wants to merge 1 commit into
facebook:masterfrom
solon:patch-2

Conversation

@solon
Copy link
Copy Markdown
Contributor

@solon solon commented Oct 3, 2019

Summary

Fixing typos

Changelog

[Internal] [Fixed] - Fixed minor typos in react-native-codegen errors

Test Plan

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2019
Copy link
Copy Markdown
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @solon in 375ef14.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 5, 2019
@solon solon deleted the patch-2 branch October 7, 2019 15:50
facebook-github-bot pushed a commit that referenced this pull request Apr 25, 2023
#26714)

Summary:
Insert temporary input node to polyfill submitter argument in FormData.
This works for buttons too and fixes a bug where the type attribute
wasn't reset.

I also exclude the submitter if it's a function action. This ensures
that we don't include the generated "name" when the action is a server
action. Conceptually that name doesn't exist.

DiffTrain build for commit facebook/react@5e5342b.

Changelog: [Internal]

Reviewed By: kassens

Differential Revision: D45240323

fbshipit-source-id: 3e9a8076942abdc24cf25b9dd9f130727ec3c0fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants