Skip to content

Linking to the ReactJS code of conduct.#26725

Closed
nearestnabors wants to merge 1 commit into
facebook:masterfrom
nearestnabors:patch-1
Closed

Linking to the ReactJS code of conduct.#26725
nearestnabors wants to merge 1 commit into
facebook:masterfrom
nearestnabors:patch-1

Conversation

@nearestnabors
Copy link
Copy Markdown
Contributor

@nearestnabors nearestnabors commented Oct 4, 2019 •
edited by rickhanlonii
Loading

Overview

Recently, React Native switched over to a new code of conduct based on the contributors' covenant here. This PR updates CONTRIBUTING.md to link to this updated CoC.

Linking to the ReactJS code of conduct.
ac246ad 
Recently the React org switched over to a new code of conduct based on the contributors' covenant here: https://github.com/facebook/react-native/blob/master/CODE_OF_CONDUCT.md
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 4, 2019
@pull-bot
Copy link
Copy Markdown

pull-bot commented Oct 4, 2019

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against ac246ad

facebook-github-bot
facebook-github-bot approved these changes Oct 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

rickhanlonii
rickhanlonii approved these changes Oct 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Oct 4, 2019

This pull request was successfully merged by @rachelnabors in cf7759e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@cpojer cpojer Awaiting requested review from cpojer

@hramos hramos Awaiting requested review from hramos

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

API: Linking CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nearestnabors @pull-bot @react-native-bot @rickhanlonii @facebook-github-bot